Copilot commented on code in PR #2932:
URL: https://github.com/apache/dubbo-go/pull/2932#discussion_r2178820903
##########
tools/dubbogo-cli/metadata/zookeeper/zookeeper.go:
##########
@@ -26,12 +26,13 @@ import (
)
import (
+ "dubbo.apache.org/dubbo-go/v3/common"
+ "dubbo.apache.org/dubbo-go/v3/metadata/definition"
+
gxzookeeper "github.com/dubbogo/gost/database/kv/zk"
)
import (
- "dubbo.apache.org/dubbo-go/v3/common"
- "dubbo.apache.org/dubbo-go/v3/metadata/definition"
"dubbo.apache.org/dubbo-go/v3/tools/dubbogo-cli/metadata"
)
Review Comment:
[nitpick] There are two separate import blocks here; consider merging them
into a single block and grouping imports (standard, external, internal) for
readability.
##########
tools/dubbogo-cli/README.md:
##########
@@ -119,20 +119,24 @@ The Demo uses the direct connection mode, without relying
on the registration ce
#### 3.1.2 Run The Demo
-Run Server
+Install dependency
-```
-$ cd go-server/cmd
-$ go run .
+```bash
+go mod tidy
```
-Run client in another terminate
+Run Server
+```bash
+cd go-server/cmd
+go run .
```
-$ go mod tidy
-$ cd go-client/cmd
-$ go run .
+Run client in another terminate
Review Comment:
Typo: 'terminate' should be 'terminal' in this instruction.
```suggestion
Run client in another terminal
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
