zrlw commented on code in PR #15523:
URL: https://github.com/apache/dubbo/pull/15523#discussion_r2187301219
##########
dubbo-rpc/dubbo-rpc-triple/src/test/java/org/apache/dubbo/rpc/protocol/tri/rest/GeneralTypeConverterTest.java:
##########
@@ -39,13 +42,13 @@ void convert() throws NoSuchFieldException {
@Test
void convert1() {
Object convert = JsonUtils.toJavaObject("[1,\"aa\"]", List.class);
- System.out.println(convert);
+ logger.info((String) convert);
Review Comment:
java.util.ArrayList cannot be cast to class java.lang.String.
list == null ? logger.info("empty list") : list.forEach(item ->
logger.info(item));
but It's not worth doing this, you'd better delete all
```System.out.println``` statements and replace them by Assertions just like
```Assertions.assertTrue(((List) convert).size() == 2);```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
