Re: [PR] feat: replace application use of config package to global package in directory of registry [dubbo-go]

[via GitHub]

marsevilspirit commented on code in PR #2942:
URL: https://github.com/apache/dubbo-go/pull/2942#discussion_r2189843964


##########
registry/directory/directory_test.go:
##########
@@ -188,6 +182,7 @@ func normalRegistryDir(noMockEvent ...bool) 
(*RegistryDirectory, *registry.MockR
 }
 
 func TestToGroupInvokers(t *testing.T) {
+

Review Comment:
   Please delete unnecessary blank lines.



##########
registry/directory/directory.go:
##########
@@ -575,14 +576,27 @@ type consumerConfigurationListener struct {
        directory *RegistryDirectory
 }
 
-func newConsumerConfigurationListener(dir *RegistryDirectory) 
*consumerConfigurationListener {
+func newConsumerConfigurationListener(dir *RegistryDirectory, url *common.URL) 
*consumerConfigurationListener {
        listener := &consumerConfigurationListener{directory: dir}
+
+       // TODO: Temporary compatibility with old APIs, can be removed later
        application := config.GetRootConfig().Application
        listener.InitWith(
                application.Name+constant.ConfiguratorSuffix,
                listener,
                extension.GetDefaultConfiguratorFunc(),
        )
+
+       if ApplicationConfRaw, ok := url.GetAttribute(constant.ApplicationKey); 
ok {

Review Comment:
   You did not set the Application Config in the Attribute field of the URL, so 
you won't get anything with get attribute.
   
   
![image](https://github.com/user-attachments/assets/55526ddb-8e8e-4d95-98c0-3be6ec23bd8b)
   
   You should try testing the code you wrote yourself to see if it works.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org