Stellar1999 commented on code in PR #15529:
URL: https://github.com/apache/dubbo/pull/15529#discussion_r2191884981
##########
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TriplePingPongHandler.java:
##########
@@ -29,21 +30,28 @@ public class TriplePingPongHandler extends
ChannelDuplexHandler {
private final long pingAckTimeout;
- private ScheduledFuture<?> pingAckTimeoutFuture;
+ private final AtomicReference<ScheduledFuture<?>> pingAckTimeoutFutureRef
= new AtomicReference<>();
Review Comment:
Yes, even if two threads use two separate connections, they should still be
different objects. As far as I remember, this frame is only sent when the
service goes offline. I can test it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
