Copilot commented on code in PR #2946:
URL: https://github.com/apache/dubbo-go/pull/2946#discussion_r2193756066
##########
client/action.go:
##########
@@ -107,7 +107,9 @@ func (refOpts *ReferenceOptions) refer(srv
common.RPCService, info *ClientInfo)
var methods []string
if info != nil {
- ref.InterfaceName = info.InterfaceName
+ if ref.InterfaceName == "" {
+ ref.InterfaceName = info.InterfaceName
+ }
methods = info.MethodNames
refOpts.id = info.InterfaceName
Review Comment:
Assigning `refOpts.id` from `info.InterfaceName` ignores any override
provided via WithInterface. Use the resolved interface name
(`refOpts.Reference.InterfaceName`) to respect the user option.
```suggestion
refOpts.id = ref.InterfaceName
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
