Alanxtl commented on PR #2947:
URL: https://github.com/apache/dubbo-go/pull/2947#issuecomment-3050961260
> Need more information, why add RegistryType, why expose two APIs?
1. Why expose two APIs
According to polaris previous implementation, `RegistryType` has two
types `service` and `interface`, and we already have `WithRegisterInterface()`
in `registry/options.go:186` which set `RegistryType` to `interface`. But we
don't have `WithRegisterService()` to set RegistryType to `service`, so I
expose it.
And I add `WithRegistryType()` because the registryType imformation
won't be Report previous
2. Why add RegistryType
Because `polaris tps limiter`'s behaviour vairous when get different
type of `RegistryType`, and previous implemention gets `RegistryType` from
`root_config`, in order to replace the use of `config`, We need to transfer
`RegistryType` in `url` so I add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
