RainYuY commented on code in PR #15542:
URL: https://github.com/apache/dubbo/pull/15542#discussion_r2204228231
##########
.github/workflows/build-and-test-pr.yml:
##########
@@ -243,8 +245,15 @@ jobs:
key: zookeeper-${{ runner.os }}-${{ env.ZOOKEEPER_VERSION }}
restore-keys: |
zookeeper-${{ runner.os }}-
- - name: "Test with maven"
+ - name: "Test with maven on JDK 8"
+ timeout-minutes: 90
+ if: ${{ matrix.jdk == '8' }}
+ run: |
+ set -o pipefail
+ ./mvnw ${{ env.MAVEN_ARGS }} clean test verify
-Pjacoco,'!jdk15ge-add-open',skip-spotless -DtrimStackTrace=false
-Dmaven.test.skip=false -Dcheckstyle.skip=false -Dcheckstyle_unix.skip=false
-Drat.skip=false -DembeddedZookeeperPath=${{ github.workspace }}/.tmp/zookeeper
2>&1 | tee >(grep -n -B 1 -A 200 "FAILURE! -- in" > test_errors.log)
Review Comment:
Why is there a special emphasis on JDK 8?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
