MoritzArena commented on PR #15537: URL: https://github.com/apache/dubbo/pull/15537#issuecomment-3077522121
> 1. if the plugin just works on jdk17+, the module should be added to jdk17+ profile, like `dubbo-spring6-security` at dubbo-parent pom (Not only this pom needs to be modified): > > ``` > <profile> > <id>jdk-version-ge-17</id> > <activation> > <jdk>[17,)</jdk> > </activation> > <modules> > ... > <module>dubbo-plugin/dubbo-spring6-security</module> > ... > </modules> > </profile> > ``` > > 2. supplement test cases to [dubbo-integration-cases]https://github.com/apache/dubbo-integration-cases / [dubbo-samples](https://github.com/apache/dubbo-samples) for the new plugin. got it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
