marsevilspirit commented on code in PR #2941: URL: https://github.com/apache/dubbo-go/pull/2941#discussion_r2231030890
########## client/options_test.go: ########## @@ -1231,3 +1232,33 @@ func TestWithKeepAliveConfig(t *testing.T) { } processNewClientCases(t, cases) } + +func TestClientOptionsInit_CopiesFromConsumer(t *testing.T) { Review Comment: Almost LGTM, but I don't like the unit test name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org