Similarityoung commented on code in PR #710:
URL: https://github.com/apache/dubbo-go-pixiu/pull/710#discussion_r2236339546
##########
pkg/prometheus/prometheus.go:
##########
@@ -382,9 +382,12 @@ func computeApproximateRequestSize(r *http.Request) (int,
error) {
return s, nil
}
-func computeApproximateResponseSize(res *client.UnaryResponse) (int, error) {
+func computeApproximateResponseSize(res interface{}) (int, error) {
Review Comment:
use any？
##########
pkg/filter/metric/metric.go:
##########
@@ -137,11 +137,14 @@ func (f *Filter) Encode(c *http.HttpContext)
filter.FilterStatus {
return filter.Continue
}
-func computeApproximateResponseSize(res any) (int, error) {
+func computeApproximateResponseSize(res interface{}) (int, error) {
Review Comment:
use any？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
