RainYuY commented on PR #15594: URL: https://github.com/apache/dubbo/pull/15594#issuecomment-3143726710
> Thank you very mush for your preview. > > In the zookeeper registry client, i have modified it to use `registry.check` directly instead of introducing new specific options. > > Can it be considered that `nacos.check` actually replaces the function of `registry.check`? So here i only need to be compatible with this situation which led to #15003. When `registry.check = false` and `nacos.check = true`, the value of `nacos.check` should be `false` actually. > > And then i will evaluate the impact of this change on the config center and metadata center. > > @RainYuY @zrlw need more review, thx The modification is OK, and I even think the nacos.check configuration item could be removed in the future. Also, what I mentioned earlier was not that this PR affects the config center or metadata, but that their behavior is inconsistent. In the current implementation of this PR, even if the check fails, the registry is still initialized. As a result, the service keeps trying to register to an unavailable registry. I think a better approach would be not to repeatedly attempt registration when the registry is unavailable. Instead, we should first check the availability of the registry, and only proceed with registration once it becomes available. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
