Copilot commented on code in PR #89:
URL:
https://github.com/apache/dubbo-go-pixiu-samples/pull/89#discussion_r2269446980
##########
llm/pixiu/conf.yaml:
##########
@@ -55,7 +57,15 @@ static_resources:
- id: 1
llm_meta:
provider: "deepseek"
+ api_key: "sk-e32da7eb2fe04b2e8284d2f5f87fa867"
Review Comment:
API key is hardcoded in the configuration file. This exposes sensitive
credentials in version control. Consider using environment variables or a
secure configuration management system instead.
```suggestion
api_key: "${DEEPSEEK_API_KEY}"
```
##########
llm/prometheus.yml:
##########
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+global:
+ evaluation_interval: 15s
+ scrape_interval: 15s
+scrape_configs:
+ - job_name: dubbo-provider
+ scrape_interval: 15s
+ scrape_timeout: 5s
+ metrics_path: /
+ static_configs:
+ - targets: ['172.22.142.171:2222']
Review Comment:
The IP address is hardcoded in the Prometheus configuration. This makes the
configuration less portable and harder to maintain across different
environments. Consider using a hostname or making this configurable through
environment variables.
```suggestion
# Use environment variable substitution to set the target address,
e.g. with envsubst
- targets: ['${DUBBO_PROVIDER_TARGET}']
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
