Similarityoung commented on code in PR #732:
URL: https://github.com/apache/dubbo-go-pixiu/pull/732#discussion_r2280538123
##########
pkg/common/constant/key.go:
##########
@@ -50,6 +50,7 @@ const (
HTTPTrafficFilter = "dgp.filter.http.traffic"
HTTPPrometheusMetricFilter = "dgp.filter.http.prometheusmetric"
HTTPFailInjectFilter = "dgp.filter.http.faultinjection"
+ HTTPAuthOPAFilter = "dgp.filter.http.opa"
Review Comment:
I have a suggestion regarding the file structure. I noticed that this new
OPA plugin and the existing authority plugin are both fundamentally
Authorization mechanisms.
To improve our architecture and standardize the terminology, what do you
think about creating a unified authorization directory for them?
My suggestion is:
Create a new directory: `.../authorization/`.
Place your new OPA logic into a subdirectory within it:
`.../authorization/opa/`.
Update the plugin name to reflect this new path:
`dgp.filter.http.authorization.opa`.
This sets a great foundation. As a follow-up, we can then migrate the simple
authority plugin into this new authorization directory in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
