AlexStocks commented on code in PR #381:
URL: https://github.com/apache/dubbo-go-hessian2/pull/381#discussion_r2291387498
##########
string.go:
##########
@@ -225,7 +222,7 @@ func (d *Decoder) decString(flag int32) (string, error) {
case (0x80 <= tag && tag <= 0xbf) || (0xc0 <= tag && tag <= 0xcf) ||
(0xd0 <= tag && tag <= 0xd7) || tag == BC_INT ||
- (tag >= 0xd8 && tag <= 0xef) || (tag >= 0xf0 && tag <= 0xff) ||
Review Comment:
没必要去掉，留下代码可读性更好
##########
long.go:
##########
@@ -124,7 +124,7 @@ func (d *Decoder) decInt64(flag int32) (int64, error) {
i8 := int8(tag - BC_LONG_ZERO)
return int64(i8), nil
- case tag >= 0xf0 && tag <= 0xff:
Review Comment:
没必要去掉，留下代码可读性更好
##########
decode.go:
##########
@@ -295,7 +295,7 @@ func (d *Decoder) DecodeValue() (interface{}, error) {
(0xd0 <= tag && tag <= 0xd7) || tag == BC_INT: //'I': //int
return d.decInt32(int32(tag))
- case (tag >= 0xd8 && tag <= 0xef) || (tag >= 0xf0 && tag <= 0xff) ||
Review Comment:
0xff 没必要去掉，留下代码可读性更好
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
