AlexStocks commented on code in PR #750: URL: https://github.com/apache/dubbo-go-pixiu/pull/750#discussion_r2317887945
########## pkg/common/http/manager_test.go: ########## @@ -318,6 +333,14 @@ func (r *StreamHTTPRecorder) Flush() { r.flushCount++ } +func (r *StreamHTTPRecorder) GetReceivedBuf() []string { + r.mu.Lock() + defer r.mu.Unlock() + bufCopy := make([]string, len(r.receivedBuf)) Review Comment: line 339 没有竞争,挪出锁外面 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org