AlexStocks commented on PR #746: URL: https://github.com/apache/dubbo-go-pixiu/pull/746#issuecomment-3261033268
···markdown Thanks for adding Nacos LLM registry support! The implementation is solid, but I have a few suggestions: 1. Add unit tests for `nacosLLMRegistry` to cover `Register`, `UnRegister`, etc. 2. Rename `nacosLLMRegistry` to `NacosLLMRegistry` for consistency. 3. Update `README.md` with Nacos LLM usage instructions. 4. Address SonarQube's 8 issues and 8.5% duplication rate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
