AlexStocks commented on code in PR #3023:
URL: https://github.com/apache/dubbo-go/pull/3023#discussion_r2345865538


##########
filter/accesslog/filter.go:
##########
@@ -214,6 +189,68 @@ func (f *Filter) OnResponse(_ context.Context, result 
result.Result, _ base.Invo
        return result
 }
 
+// start initializes and starts the background goroutine for processing logs
+func (f *Filter) start() {

Review Comment:
   把原来的 go func() 改为 start() + processLogs(),为何不是把所有代码放进 start() 同一个函数里面?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

Reply via email to