wuwen5 commented on PR #92: URL: https://github.com/apache/dubbo-hessian-lite/pull/92#issuecomment-3307471039
> I found there are other xxxSerializers which are more complex such as `LocalDateTimeSerializer`, these xxxSerializer also need to be optimized for the sake of performance. The samplest way might be putting `addRef` at the beginning of their `writeObject` method (but after null checking), but it might be better to add abstract `writeObjectInternal` method to `AbstractSerializer` which will call `writeObjectInternal` when `writeReplace` returns null, and there xxxSerializer override `writeObjectInternal` method instead of overriding `writeObject`, just like `writeReplace` method does. @zrlw I think we can call `super.writeObject(obj, out)` in the here, and also implement a `writeReplace()` method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
