Copilot commented on code in PR #3029:
URL: https://github.com/apache/dubbo-go/pull/3029#discussion_r2365561117
##########
cluster/router/polaris/router.go:
##########
@@ -67,9 +72,11 @@ func newPolarisRouter() (*polarisRouter, error) {
}
return &polarisRouter{
- openRoute: true,
- routerAPI: routerAPI,
- consumerAPI: consumerAPI,
+ openRoute: true,
+ routerAPI: routerAPI,
+ consumerAPI: consumerAPI,
+ currentApplication: application.(string),
+ Registries:
registries.(map[string]*global.RegistryConfig),
Review Comment:
Unsafe type assertions without checking if the type conversion is valid. If
`application` is not a string or `registries` is not the expected map type,
this will cause a panic at runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
