oxsean commented on code in PR #15699:
URL: https://github.com/apache/dubbo/pull/15699#discussion_r2367459141
##########
dubbo-common/src/main/java/org/apache/dubbo/common/config/ConfigurationUtils.java:
##########
@@ -501,4 +505,29 @@ public static String getProperty(String property, String
defaultValue) {
public static int get(String property, int defaultValue) {
return get(ApplicationModel.defaultModel(), property, defaultValue);
}
+
+ private static volatile Set<String> SensitiveParameterNames;
+
+ public static boolean isSensitiveParameter(URL url, String name) {
+ if (SensitiveParameterNames == null) {
+ synchronized (ConfigurationUtils.class) {
+ if (SensitiveParameterNames == null) {
+ Set<String> names = new HashSet<>();
+ // Always include default sensitive parameters
+ names.add(CommonConstants.PASSWORD_KEY);
Review Comment:
If the user has set it, just use the user’s value, maybe they really do want
to print the secretKey to troubleshoot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
