yumosx commented on PR #3055: URL: https://github.com/apache/dubbo-go/pull/3055#issuecomment-3419256338
> > > Ur impl is a bit of a hassle, u can refer to what I've done in pixiu, use `git diff --exit-code`, see https://github.com/apache/dubbo-go-pixiu/blob/develop/.github/workflows/github-actions.yml line 57 and 62 > > > > > > 对这种方式在 CI 中直接使用没有问题，也非常简单高效。 > > 但在 Makefile 中使用时，如果工作区存在未提交的文件，执行 fmt 后这些文件也会出现在报错信息里，而实际上它们并非由 fmt 导致。 > > 因此，Copilot 提到的做法虽然比较复杂，但是确是严谨的。 > > I have no clue why makefile need to have this func, does any issue linked to this? The only use case for this func is within the CI system, why users need `check-fmt` in makefile? Seems like you're right👍. It's my mistake. I overthought it. I adjust it later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
