zrlw commented on code in PR #15594:
URL: https://github.com/apache/dubbo/pull/15594#discussion_r2439500304
##########
dubbo-remoting/dubbo-remoting-zookeeper-curator5/src/test/java/org/apache/dubbo/remoting/zookeeper/curator5/Curator5ZookeeperClientManagerTest.java:
##########
@@ -18,36 +18,55 @@
import org.apache.dubbo.common.URL;
+import org.apache.curator.framework.CuratorFramework;
+import org.apache.curator.framework.CuratorFrameworkFactory;
+import org.apache.curator.framework.listen.StandardListenerManager;
import org.junit.jupiter.api.AfterAll;
+import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
-import org.mockito.MockedConstruction;
+import org.mockito.MockedStatic;
+import static org.apache.dubbo.common.constants.CommonConstants.CHECK_KEY;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.core.IsNot.not;
import static org.hamcrest.core.IsNull.nullValue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.anyInt;
+import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.mockConstructionWithAnswer;
+import static org.mockito.Mockito.mockStatic;
+import static org.mockito.Mockito.spy;
+import static org.mockito.Mockito.when;
class Curator5ZookeeperClientManagerTest {
private ZookeeperClient zookeeperClient;
- private static MockedConstruction<Curator5ZookeeperClient>
mockedCurator5ZookeeperClientConstruction;
- private static String zookeeperConnectionAddress1;
+ private static URL zookeeperUrl;
+ private static MockedStatic<CuratorFrameworkFactory>
curatorFrameworkFactoryMockedStatic;
+ private CuratorFramework mockCuratorFramework;
@BeforeAll
public static void beforeAll() {
- zookeeperConnectionAddress1 = "zookeeper://127.0.0.1:2181";
- Curator5ZookeeperClient mockCurator5ZookeeperClient =
mock(Curator5ZookeeperClient.class);
- mockedCurator5ZookeeperClientConstruction =
- mockConstructionWithAnswer(Curator5ZookeeperClient.class,
invocationOnMock -> invocationOnMock
- .getMethod()
- .invoke(mockCurator5ZookeeperClient,
invocationOnMock.getArguments()));
+ String zookeeperConnectionAddress1 = "zookeeper://127.0.0.1:2181";
+ zookeeperUrl = URL.valueOf(zookeeperConnectionAddress1 + "/service");
+
+ CuratorFrameworkFactory.Builder realBuilder =
CuratorFrameworkFactory.builder();
+ CuratorFrameworkFactory.Builder spyBuilder = spy(realBuilder);
Review Comment:
it might conflict with line 78: CuratorFrameworkFactory.Builder spyBuilder =
CuratorFrameworkFactory.builder();
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
