zrlw commented on code in PR #15721:
URL: https://github.com/apache/dubbo/pull/15721#discussion_r2443309045
##########
dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/reference/ReferenceBeanManager.java:
##########
@@ -154,6 +154,10 @@ public void prepareReferenceBeans() throws Exception {
for (ReferenceBean referenceBean : getReferences()) {
initReferenceBean(referenceBean);
}
+ // add a null check for moduleModel to be compatible with the native
environment
Review Comment:
lazy getting ```moduleModel``` at prepareReferenceBeans might be better.
https://github.com/apache/dubbo/issues/15663#issuecomment-3417865576
##########
dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/reference/ReferenceBeanManager.java:
##########
@@ -154,6 +154,10 @@ public void prepareReferenceBeans() throws Exception {
for (ReferenceBean referenceBean : getReferences()) {
initReferenceBean(referenceBean);
}
+ // add a null check for moduleModel to be compatible with the native
environment
Review Comment:
It is inappropriate to check `moduleModel` at here, and you should not use
force-push before you know what you do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
