Alanxtl commented on code in PR #3034:
URL: https://github.com/apache/dubbo-go/pull/3034#discussion_r2445016274
##########
protocol/grpc/server.go:
##########
@@ -199,14 +224,16 @@ func waitGrpcExporter(providerServices
map[string]*config.ServiceConfig) {
}
// registerService SetProxyImpl invoker and grpc service
-func registerService(providerServices map[string]*config.ServiceConfig, server
*grpc.Server) {
+// TODO #2741 old config compatibility
+func registerService(providerServices map[string]*global.ServiceConfig, server
*grpc.Server) {
for key, providerService := range providerServices {
+
+ //TODO: Temporary compatibility with old APIs, can be removed
later
service := config.GetProviderService(key)
Review Comment:
这行对config的依赖在后文并没有看到替代的地方
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
