Alanxtl commented on code in PR #3065:
URL: https://github.com/apache/dubbo-go/pull/3065#discussion_r2469476108
##########
compat.go:
##########
@@ -40,6 +40,11 @@ func compatRootConfig(c *InstanceOptions) *config.RootConfig
{
regCompat[k] = compatRegistryConfig(v)
}
+ rouCompat := make([]*config.RouterConfig, 0)
+ for _, v := range c.Router {
+ rouCompat = append(rouCompat, compatRouterConfig(v))
+ }
+
Review Comment:
```suggestion
routeCompat := make([]*config.RouterConfig, 0)
for _, v := range c.Router {
routeCompat = append(routeCompat , compatRouterConfig(v))
}
```
##########
compat.go:
##########
@@ -52,6 +57,7 @@ func compatRootConfig(c *InstanceOptions) *config.RootConfig {
Otel: compatOtelConfig(c.Otel),
Logger: compatLoggerConfig(c.Logger),
Shutdown: compatShutdownConfig(c.Shutdown),
+ Router: rouCompat,
Review Comment:
```suggestion
Router: routeCompat,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
