qxggg commented on code in PR #15738:
URL: https://github.com/apache/dubbo/pull/15738#discussion_r2473475172
##########
dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/exchange/support/DefaultFuture.java:
##########
@@ -328,8 +328,7 @@ public void run(Timeout timeout) {
try {
executor.execute(() -> notifyTimeout(future));
} catch (RejectedExecutionException e) {
- notifyTimeout(future);
- throw e;
+ notifyExecutionError(future, e);
Review Comment:
We catch RejectedExecutionException so that we can handle it internally with
notifyExecutionError. This prevents unhandled exceptions from propagating
unnecessarily.
Do you think we should still rethrow it to the caller? If so, I can add
throw e immediately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
