Anshul-creator opened a new pull request, #15778:
URL: https://github.com/apache/dubbo/pull/15778
## What is the purpose of the change?
This PR stabilizes the following three tests in `ExporterSideConfigUrlTest`:
- `exporterMethodConfigUrlTest`
- `exporterServiceConfigUrlTest`
- `exporterProviderConfigUrlTest`
These tests were intermittently failing under randomized execution orders
due to nondeterministic behavior in Micrometer’s composite meter registry,
which was being initialized during Dubbo’s metrics setup, even though these
URL-related tests do not depend on metrics.
## Root Cause
When `servConf.export()` is invoked inside `verifyExporterUrlGeneration`,
Dubbo triggers `DefaultApplicationDeployer.initialize()`, which initializes
metrics reporters (Prometheus by default).
During this initialization, Micrometer’s `CompositeMeterRegistry` iterates
through an internal `IdentityHashMap` whose iteration order is not
deterministic under randomized JVM execution orders.
Under certain NonDex seeds, this produces:
```lua
java.lang.ArrayIndexOutOfBoundsException
at java.util.IdentityHashMap$KeyIterator.next(...)
at
io.micrometer.core.instrument.composite.CompositeMeterRegistry.updateDescendants(...)
```
This exception happens before the test even begins validating URL
parameters, making the failure unrelated to URL behavior.
The test suite never intended to validate metrics behavior here, so metrics
initialization adds unnecessary non-determinism.
## Changes Made
- Added explicit test-local configuration to disable the metrics subsystem
for every test execution in this class
- Ensured cleanup via `SysProps.clear()` in both `@BeforeEach` and
`@AfterEach` to preserve isolation.
- Preserved the existing test structure and behavior.
## Verification
You can try running the following snippet of code from the dubbo repo root,
on both pre-fix and post-fix code
```bash
./mvnw -q -pl dubbo-config/dubbo-config-api \
edu.illinois:nondex-maven-plugin:2.2.1:nondex \
-DnondexRuns=20
```
The tests should fail intermittently on the pre-fix version, but pass
consistently across all seeds on the post-fix version.
NonDex run logs will be available under the
`dubbo-config/dubbo-config-api/.nondex` directory.
## Checklist
- [x] Make sure there is a
[GitHub_issue](https://github.com/apache/dubbo/issues) field for the change.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Write necessary unit-test to verify your logic correction. If the new
feature or significant change is committed, please remember to add sample in
[dubbo samples](https://github.com/apache/dubbo-samples) project.
- [x] Make sure gitHub actions can pass. [Why the workflow is failing and
how to fix it?](../CONTRIBUTING.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
