No-SilverBullet commented on code in PR #3086:
URL: https://github.com/apache/dubbo-go/pull/3086#discussion_r2591732912
##########
tools/dubbogo-cli/generator/sample/hessian/generator.go:
##########
@@ -99,6 +99,13 @@ func scanFile(filePath string) (file *fileInfo, err error) {
stack := make([][]byte, 0)
var line []byte
var lineSize int
+ var (
+ packageRegexp = regexp.MustCompile(PackageRegexp)
+ initFunctionRegexp = regexp.MustCompile(InitFunctionRegexp)
+ hessianImportRegexp = regexp.MustCompile(HessianImportRegexp)
+ lineCommentRegexp = regexp.MustCompile(LineCommentRegexp)
+ hessianPOJORegexp = regexp.MustCompile(HessianPOJORegexp)
+ )
Review Comment:
These changes appear to duplicate with
https://github.com/apache/dubbo-go/pull/3099. Please readjust them, either
keeping the PR and changing its description, or removing the duplicate changes
from this PR.
##########
protocol/triple/client.go:
##########
@@ -59,25 +63,40 @@ const (
type clientManager struct {
isIDL bool
// triple_protocol clients, key is method name
Review Comment:
add a RW lock here to protect this map
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
