Chen-BUPT commented on code in PR #833:
URL: https://github.com/apache/dubbo-go-pixiu/pull/833#discussion_r2602925908


##########
pkg/adapter/dubboregistry/registry/zookeeper/registry.go:
##########
@@ -53,9 +52,6 @@ const (
 
 func init() {
        registry.SetRegistry(constant.Zookeeper, newZKRegistry)
-       hessian.RegisterPOJO(&dubboCommon.MetadataInfo{})
-       hessian.RegisterPOJO(&dubboCommon.ServiceInfo{})
-       hessian.RegisterPOJO(&dubboCommon.URL{})

Review Comment:
   yeah ,those POJOs are auto‑registered by 
dubbo.apache.org/dubbo-go/v3/metadata/info via its init(). We keep the _ import 
so Hessian registration still happens; explicit hessian.RegisterPOJO calls are 
no longer needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to