Alanxtl commented on PR #3114: URL: https://github.com/apache/dubbo-go/pull/3114#issuecomment-3658542250
1. the base branch should be develop, the modification for `tools/dubbogo-cli/generator/sample/hessian/constant.go` and `tools/dubbogo-cli/generator/sample/hessian/generator.go` are the commit in main branch, do not commit them to develop branch 2. the modification for `Makefile` has already been done in https://github.com/apache/dubbo-go/pull/3109 u don't need to modify `Makefile`, the CI problem have been fixed in develop branch, u just need to make sure the target branch is develop. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
