RainYuY commented on code in PR #15879:
URL: https://github.com/apache/dubbo/pull/15879#discussion_r2629272615
##########
dubbo-metadata/pom.xml:
##########
@@ -35,11 +35,11 @@
</modules>
<dependencies>
- <dependency>
- <groupId>org.apache.dubbo</groupId>
- <artifactId>dubbo-test-check</artifactId>
- <version>${project.parent.version}</version>
- <scope>test</scope>
- </dependency>
+ <!-- <dependency>-->
Review Comment:
Just delete them.
##########
dubbo-metadata/dubbo-metadata-api/src/test/java/org/apache/dubbo/metadata/MetadataInfoTest.java:
##########
@@ -198,10 +196,6 @@ void testJdkSerialize() throws IOException,
ClassNotFoundException, NoSuchFieldE
objectInputStream.close();
Assertions.assertEquals(metadataInfo, metadataInfo2);
- Field initiatedField =
MetadataInfo.class.getDeclaredField("initiated");
Review Comment:
Why remove Assertions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
