zbchi opened a new pull request, #3135:
URL: https://github.com/apache/dubbo-go/pull/3135
## Summary
Improve unit test coverage for the `cluster` package and fix a boundary
check bug in argument matcher.
## Changes
- Add unit tests for cluster package functionality:
- `cluster/cluster/`:
- `interceptor_invoker_test.go`: Interceptor chain building and
management
- `mock_test.go`: Mock invoker and cluster implementations
- `cluster/loadbalance/`:
- `aliasmethod/alias_method_test.go`: Alias method picker for weighted
load balancing
- `iwrr/iwrr_test.go`: Interleaved weighted round-robin queue operations
- `util_test.go`: Weight calculation with warmup and priority handling
- `cluster/metrics/`:
- `local_metrics_test.go`: Local metrics storage and concurrent access
- `utils_test.go`: Invoker and instance key generation utilities
- `cluster/router/`:
- `condition/matcher/argument_test.go`: Argument condition matcher
- `condition/matcher/attachment_test.go`: Attachment condition matcher
- `condition/matcher/base_test.go`: Base condition matcher and sorting
- `options_test.go`: Router configuration options
- `script/instance/instances_pool_test.go`: Script router instance pool
- `cluster/utils/`:
- `adaptivesvc_test.go`: Adaptive service error handling
- `version_test.go`: Version parsing and comparison
- Fix bug in `cluster/router/condition/matcher/argument.go`:
- Fix boundary check from `index > len(...)` to `index >= len(...)` to
prevent index out of range panic
### Checklist
- [ ] I confirm the target branch is `develop`
- [ ] Code has passed local testing
- [ ] I have added tests that prove my fix is effective or that my feature
works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
