krrishmahar opened a new pull request, #15974:
URL: https://github.com/apache/dubbo/pull/15974
## What is the purpose of the change?
This PR addresses issue #15935 by improving IPv6-related test coverage in
`NetUtils`.
Specifically, it:
- Adds unit tests for IPv6 address normalization without scope.
- Verifies IPv6 CIDR matching behavior in `matchIpExpression`.
- Ensures unsupported IPv6 wildcard patterns fail fast with clear exceptions.
- Validates mismatched IPv4 pattern and IPv6 host scenarios.
- Documents current implementation-defined behavior via tests, without
modifying runtime logic.
No functional behavior is changed; this PR focuses on correctness, clarity,
and maintainability through testing.
## Brief changelog
- **NetUtilsTest.java**
- Added IPv6 normalization tests.
- Added IPv6 CIDR and invalid pattern matching tests.
- Added validation for IPv4/IPv6 mismatch cases.
- Documented unsupported IPv6 wildcard behavior.
## Verifying this change
Validated locally by running:
```bash
mvn test -Dtest=NetUtilsTest -pl dubbo-common
```
And verify build by running:
```bash
./mvnw -e --batch-mode --no-snapshot-updates --no-transfer-progress
--fail-fast clean install -Psources,skip-spotless,checkstyle
-Dmaven.test.skip=true
```
## Checklist
- [x] Make sure there is a
[GitHub_issue](https://github.com/apache/dubbo/issues) field for the change.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Write necessary unit-test to verify behavior. No production logic is
changed.
- [x] Make sure GitHub Actions can pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
