Tsukikage7 commented on PR #856:
URL: https://github.com/apache/dubbo-go-pixiu/pull/856#issuecomment-3789646637
> 1. what's the difference between the proto file in
`tools/benchmark/api/grpcstub/benchmark.proto` and the proto file in
`tools/benchmark/api/benchmark.proto` can't we use the same proto file?
> 2. why dubbo direct has 6 interfaces? why not delete `GetUser2` and
`GetErr`?
Thanks for the suggestions!
1. Proto file: Removed the duplicate grpcstub/benchmark.proto. Now both gRPC
and Triple stubs
are generated from a single api/benchmark.proto using protoc's
--go_opt=M... flag.
2. Dubbo interfaces: Removed GetUser2, GetUser3, GetErr and other redundant
methods. Now
dubbo keeps only 4 core interfaces (GetUser, GetUser0, GetUsers, GetGender),
aligned with the
benchmark purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
