SURYAS1306 opened a new pull request, #16058:
URL: https://github.com/apache/dubbo/pull/16058

   ## What is the purpose of the change?
   
   When using Triple through gateways like APISIX, the client may receive a 
non-gRPC HTTP response (for example `text/plain` like `"Hello"`).  
   Previously, the Triple client still initialized the deframer and attempted 
to decode the payload, which led to parsing errors and `CANCELLED` exceptions.
   
   This change makes the Triple client **fail fast** when response headers are 
invalid:
   - immediately cancels the stream
   - prevents deframer creation
   - ensures non-gRPC HTTP bodies never enter the gRPC decoder
   
   This avoids incorrect decoding and provides a clearer failure path.
   
   Related issue: #15968
   
   ---
   
   ## What was changed?
   
   - Added early cancellation when header validation fails in `onHeaderReceived`
   - Ensured invalid responses never reach the deframer
   - Kept existing DATA-frame guard as a second safety layer
   
   ---
   
   ## How was this tested?
   
   - `mvn -pl dubbo-rpc/dubbo-rpc-triple -am test`
   - Full build on branch `3.3`
   
   ---
   
   ## Checklist
   
   - [x] Make sure there is a GitHub issue for the change  
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why  
   - [] Write necessary unit-test to verify your logic correction (not added; 
transport-layer behavior validated by build and manual verification)  
   - [x] Make sure GitHub actions can pass  
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to