Alanxtl commented on code in PR #3195:
URL: https://github.com/apache/dubbo-go/pull/3195#discussion_r2771866249


##########
global/logger_config.go:
##########
@@ -99,3 +112,27 @@ func (f *File) Clone() *File {
                Compress:   f.Compress,
        }
 }
+
+// Clone a new TraceIntegrationConfig
+func (t *TraceIntegrationConfig) Clone() *TraceIntegrationConfig {
+       if t == nil {
+               return nil
+       }
+
+       var newEnabled *bool
+       if t.Enabled != nil {
+               newEnabled = new(bool)
+               *newEnabled = *t.Enabled
+       }
+
+       var newRecordErrorToSpan *bool
+       if t.RecordErrorToSpan != nil {
+               newRecordErrorToSpan = new(bool)
+               *newRecordErrorToSpan = *t.RecordErrorToSpan

Review Comment:
   ditto



##########
global/logger_config.go:
##########
@@ -99,3 +112,27 @@ func (f *File) Clone() *File {
                Compress:   f.Compress,
        }
 }
+
+// Clone a new TraceIntegrationConfig
+func (t *TraceIntegrationConfig) Clone() *TraceIntegrationConfig {
+       if t == nil {
+               return nil
+       }
+
+       var newEnabled *bool
+       if t.Enabled != nil {
+               newEnabled = new(bool)
+               *newEnabled = *t.Enabled

Review Comment:
   ```suggestion
                e := *t.Enabled
                newEnabled = &e
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to