Snow-kal opened a new pull request, #3211:
URL: https://github.com/apache/dubbo-go/pull/3211

   protocol/dubbo3/internal/client.go
   已移除 config
   按照 TODO 删除测试
   
   protocol/dubbo3/internal/server.go
   已移除 config
   按照 TODO 删除测试
   
   protocol/grpc/internal/helloworld/client.go
   已移除 config
   
   protocol/grpc/internal/routeguide/client.go
   已移除 config
   
   后两个文件的 config 涉及 init 函数
   
   关于 init 函数说明:
   
   在旧的 config 注册表里做自动注册。移除 config 后有两个选择
   
   继续自动注册:把“按接口名注册”的能力迁到包里(比如 dubbo 或一个新 registry 包),并同步替换调用方。
   
   放弃自动注册:直接删除 init(),在业务启动处显式注册或在 URL 上挂 
constant.RpcServiceKey。这样不需要注册表,但要保证调用处把服务实例传进去。
   
   这里先采用第一个方法,如何不是很理想的话还可以换成第二种
   
   改动位置:
   注册表与接口名注册函数新增在 dubbo.go
   自动注册恢复在 client.go 和 client.go
   查找改为 
dubbo.GetConsumerServiceByInterfaceName:client.go、dubbo3_invoker.go、dubbo3_invoker.go
   
   ### Description
   https://github.com/apache/dubbo-go/issues/3204
   
   ### Checklist
   - [ √] I confirm the target branch is `develop`
   - [ √] Code has passed local testing
   - [ √] I have added tests that prove my fix is effective or that my feature 
works
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to