Alanxtl commented on code in PR #3207:
URL: https://github.com/apache/dubbo-go/pull/3207#discussion_r2801936796
##########
internal/config.go:
##########
@@ -124,7 +131,7 @@ func translateRegistryAddress(registriesConfig
*global.RegistryConfig) string {
u, err := url.Parse(addr)
if err != nil {
logger.Errorf("The registry url is invalid, error:
%#v", err)
- panic(err)
+ return addr
Review Comment:
直接return addr也不合理吧 下游拿到没格式化的addr可能会发生问题
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
