yangpixi commented on code in PR #3225:
URL: https://github.com/apache/dubbo-go/pull/3225#discussion_r2870577703
##########
cluster/directory/static/directory.go:
##########
@@ -45,7 +47,14 @@ func NewDirectory(invokers []protocolbase.Invoker)
*directory {
invokers: invokers,
}
- dir.RouterChain().SetInvokers(invokers)
+ err := dir.BuildRouterChain(invokers, url)
+ if err != nil {
+ logger.Error(err)
+ if routerChain := dir.RouterChain(); routerChain != nil {
+ routerChain.SetInvokers(invokers)
Review Comment:
应该不需要log了，如果buildRouterChain出错了，前面就log过了，这里是failback机制
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
