Snow-kal commented on code in PR #3231:
URL: https://github.com/apache/dubbo-go/pull/3231#discussion_r2901430939
##########
protocol/dubbo3/dubbo3_invoker.go:
##########
@@ -72,20 +71,16 @@ func NewDubboInvoker(url *common.URL) (*DubboInvoker,
error) {
rt string
consumerService any
)
- // TODO: Temporary compatibility with old APIs, can be removed later
- rt = config.GetConsumerConfig().RequestTimeout
+ rt = global.DefaultConsumerConfig().RequestTimeout
Review Comment:
感谢建议 目前已经是这个逻辑了 可以看看是否有问题
```
rt = global.DefaultConsumerConfig().RequestTimeout // 先用默认值 "3s"
if consumerConfRaw, ok := url.GetAttribute(constant.ConsumerConfigKey); ok {
if consumerConf, ok := consumerConfRaw.(*global.ConsumerConfig); ok {
rt = consumerConf.RequestTimeout // 有用户配置则覆盖
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
