Alanxtl commented on code in PR #3244:
URL: https://github.com/apache/dubbo-go/pull/3244#discussion_r2935042652
##########
global/config_test.go:
##########
@@ -710,9 +710,10 @@ func TestRegistryConfigClone(t *testing.T) {
assert.Equal(t, reg.UseAsMetaReport, cloned.UseAsMetaReport)
assert.Equal(t, reg.UseAsConfigCenter, cloned.UseAsConfigCenter)
assert.NotSame(t, reg, cloned)
- assert.NotSame(t, reg.Params, cloned.Params)
assert.Equal(t, "value1", cloned.Params["key1"])
assert.Equal(t, "value2", cloned.Params["key2"])
+ cloned.Params["key1"] = "changed"
Review Comment:
这个assert.NotSame在go的新版本里面被改了，在这个场景下用会报错，所以我用了clone 来替代
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
