Rynzie02 commented on code in PR #1055:
URL: https://github.com/apache/dubbo-go-samples/pull/1055#discussion_r2944052440
##########
generic/java-server/src/main/java/org/apache/dubbo/samples/ApiProvider.java:
##########
@@ -47,19 +37,16 @@ public static void main(String[] args) throws
InterruptedException {
tripleService.setVersion(SERVICE_VERSION);
tripleService.setProtocol(new ProtocolConfig("tri", TRIPLE_PORT));
- // Register provider to ZooKeeper
- RegistryConfig registryConfig = new RegistryConfig();
- registryConfig.setAddress(ZOOKEEPER_ADDRESS);
+ // No registry: expose directly on the configured ports
+ RegistryConfig registryConfig = new RegistryConfig("N/A");
DubboBootstrap bootstrap = DubboBootstrap.getInstance();
bootstrap.application("generic-java-server")
.registry(registryConfig)
- .service(dubboService)
.service(tripleService)
Review Comment:
I think "N/A" is more appropriate than `RegistryConfig.NO_AVAILABLE`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
