Oxidaner commented on code in PR #3235:
URL: https://github.com/apache/dubbo-go/pull/3235#discussion_r2969114079
##########
filter/graceful_shutdown/consumer_filter.go:
##########
@@ -50,27 +54,61 @@ func init() {
}
type consumerGracefulShutdownFilter struct {
- shutdownConfig *global.ShutdownConfig
+ shutdownConfig *global.ShutdownConfig
+ closingEventHandler gracefulshutdown.ClosingEventHandler
+ closingInvokers sync.Map // map[string]time.Time (url key -> expire
time)
}
+const consumerCountMarkedKey = "dubbo-go-graceful-shutdown-consumer-counted"
+
func newConsumerGracefulShutdownFilter() filter.Filter {
if csf == nil {
csfOnce.Do(func() {
Review Comment:
这些是常量是包内私有,单文件内使用,确定要上提吗
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
