nagisa-kunhah commented on code in PR #3282:
URL: https://github.com/apache/dubbo-go/pull/3282#discussion_r3004529368
##########
common/url.go:
##########
@@ -102,6 +96,7 @@ type URL struct {
Port string
PrimitiveURL string
+ primitiveTS string
Review Comment:
primitiveTS just caches the original timestamp from c.PrimitiveURL.
Previously, GetCacheInvokerMapKey() reparsed PrimitiveURL and used that value,
not the current mutable params. This keeps the same behavior and only removes
the extra allocation.
https://github.com/apache/dubbo-go/blob/fb8eff2f090851261e2d1acfc55414ede91ca9c0/common/url.go#L418-L428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
