already rename the constant value to TELNET_ENABLED to keep it's name the same 
as ProtocolConfig#telnetEnabled
about to add a method like 
```
private Boolean isTenletEnabled(Channel channel) {
return channel.getUrl().getParameter(Constants.TELNET, true);
}
```
I think is unnecessary,Does anyone have a different opinion? We can discuss it.

[ Full content available at: 
https://github.com/apache/incubator-dubbo/pull/2809 ]
This message was relayed via gitbox.apache.org for 
[email protected]

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to