CAICAIIs opened a new pull request, #3320: URL: https://github.com/apache/dubbo-go/pull/3320
## Summary Keep `InstanceOptions` as the source of truth after init, instead of overwriting it from the legacy `config.RootConfig` compatibility layer. ## Why Some fields exist only in `global` configs and cannot be represented by the old `config` package. The final `config -> global` roundtrip may drop those fields. ## Changes - Remove the final `compatInstanceOptions(rcCompat, rc)` overwrite in `InstanceOptions.init` - Move legacy `config.SetRootConfig` sync behind compat helper - Add regression test for preserving global-only config ## Test ```bash go test . -run TestInstanceInitKeepsGlobalOnlyConfig -count=1 go test . ./config ./server ./client ./graceful_shutdown -count=1 go test ./... ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
