Aetherance commented on code in PR #3305:
URL: https://github.com/apache/dubbo-go/pull/3305#discussion_r3214746770


##########
cluster/router/tag/router.go:
##########
@@ -52,6 +57,14 @@ func (p *PriorityRouter) Route(invokers []base.Invoker, url 
*common.URL, invocat
                logger.Warnf("[tag router] invokers from previous router is 
empty")
                return invokers
        }
+
+       if p.cache != nil {
+               fullInvokers, pool := p.cache.FindAddrPoolWithInvokers(p)

Review Comment:
   确实存在这个问题,目前已修复
   通过引入 RouterCacheDisable 标志,Cache 现在仅在以下两个条件同时满足时生效:
   1. tag router 是 chain 中第一个被调用的 router(前面没有其他 router 处理过 invokers)
   2. invoker 列表未被 ServiceKey 过滤改变



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to