Alanxtl commented on code in PR #3311:
URL: https://github.com/apache/dubbo-go/pull/3311#discussion_r3239314413
##########
cluster/router/condition/dynamic_router.go:
##########
@@ -66,7 +66,7 @@ func (m *multiplyConditionRoute) route(invokers
[]base.Invoker, url *common.URL,
if len(m.trafficDisabled) != 0 {
for _, cond := range m.trafficDisabled {
if cond.MatchRequest(url, invocation) {
- logger.Warnf("Request has been disabled %s by
Condition.trafficDisable.match=\"%s\"", url.String(), cond.rule)
+ logger.Warnf("[Condition] request traffic
disabled: url=%s, rule=%s", url.String(), cond.rule)
Review Comment:
```suggestion
logger.Warnf("[Router][Condition] request
traffic disabled: url=%s, rule=%s", url.String(), cond.rule)
```
其他同理
##########
cluster/router/tag/router.go:
##########
@@ -82,23 +82,23 @@ func (p *PriorityRouter) Notify(invokers []base.Invoker) {
}
application := invokers[0].GetURL().GetParam(constant.ApplicationKey,
"")
if application == "" {
- logger.Warn("url application is empty, tag router will not be
enabled")
+ logger.Warn("[Router] [Tag] url application is empty, tag
router will not be enabled")
return
}
dynamicConfiguration := conf.GetEnvInstance().GetDynamicConfiguration()
if dynamicConfiguration == nil {
- logger.Infof("Config center does not start, Tag router will not
be enabled")
+ logger.Info("Config center does not start, Tag router will not
be enabled")
Review Comment:
info也加前缀
##########
cluster/router/condition/matcher/base.go:
##########
@@ -118,7 +118,7 @@ func doPatternMatch(pattern string, value string, url
*common.URL, invocation ba
}
}
// If no value matcher is available, will force to use wildcard value
matcher
- logger.Error("Executing condition rule value match expression error,
will force to use wildcard value matcher")
+ logger.Errorf("[Matcher] no matching value pattern found, using
wildcard: pattern=%s", pattern)
Review Comment:
```suggestion
logger.Errorf("[Router][Condition] no matching value pattern found,
using wildcard: pattern=%s", pattern)
```
##########
cluster/router/condition/route.go:
##########
@@ -85,7 +85,7 @@ func (s *StateRouter) Route(invokers []base.Invoker, url
*common.URL, invocation
}
if len(s.thenCondition) == 0 {
- logger.Warn("condition state router thenCondition is empty")
+ logger.Warn("[Router] [Condition] thenCondition is empty")
Review Comment:
```suggestion
logger.Warn("[Router][Condition] thenCondition is empty")
```
##########
cluster/router/condition/route.go:
##########
@@ -85,7 +85,7 @@ func (s *StateRouter) Route(invokers []base.Invoker, url
*common.URL, invocation
}
if len(s.thenCondition) == 0 {
- logger.Warn("condition state router thenCondition is empty")
+ logger.Warn("[Router] [Condition] thenCondition is empty")
Review Comment:
都改成中间不加空格的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
