Alanxtl commented on code in PR #3324:
URL: https://github.com/apache/dubbo-go/pull/3324#discussion_r3252410145
##########
common/extension/otel_trace.go:
##########
@@ -48,9 +48,9 @@ func GetTraceShutdownCallback() func() {
for name, createFunc := range traceExporterMap.Snapshot() {
if exporter, err := createFunc(nil); err == nil {
if err :=
exporter.GetTracerProvider().Shutdown(context.Background()); err != nil {
- logger.Errorf("Graceful shutdown ---
Failed to shutdown trace provider %s, error --- %s", name, err.Error())
+ logger.Errorf("[Trace] graceful
shutdown failed to shutdown trace provider, name=%s err=%v", name, err)
} else {
- logger.Infof("Graceful shutdown ---
Tracer provider of %s", name)
+ logger.Infof("[Trace] graceful shutdown
trace provider completed, name=%s", name)
Review Comment:
```suggestion
logger.Errorf("[GracefulShutdown]
failed to shutdown trace provider, name=%s err=%v", name, err)
} else {
logger.Infof("[GracefulShutdown]
shutdown trace provider completed, name=%s", name)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
