mochengqian commented on code in PR #149:
URL:
https://github.com/apache/dubbo-go-pixiu-samples/pull/149#discussion_r3252609744
##########
gateway/helloworld/deployment.yaml:
##########
@@ -40,6 +40,21 @@ spec:
selector:
app: dubbo-go-server
---
+apiVersion: gateway.networking.k8s.io/v1
Review Comment:
新增 ReferenceGrant gateway.networking.k8s.io/v1 后，这实际提高了 Gateway API CRD
版本要求。这个最低版本要求没有被记录，会导致旧 CRD 环境下 apply 失败。样例实际依赖支持该版本的 Gateway API
CRD；但仓库没有记录这个最低 CRD 版本或安装步骤。尤其 gateway/helloworld/deployment.yaml 原本只依赖
core/apps API，现在单独 apply 也需要 Gateway API CRD，这个行为变化需要文档说明。
建议在仓库里补一处可见说明，至少写清楚 gateway 样例 apply 顺序、Gateway API v1.5+、Pixiu CRD
安装方式。或者把所需 CRD fixture 纳入样例路径，让 issue 里“CRD fixture / 安装前置条件”落地。
##########
gateway/helloworld/deployment.yaml:
##########
@@ -40,6 +40,21 @@ spec:
selector:
app: dubbo-go-server
---
+apiVersion: gateway.networking.k8s.io/v1
+kind: ReferenceGrant
Review Comment:
不要把 ReferenceGrant 留在 backend deployment 文件里。移动到 gateway/http/http.yaml
是最小、最干净的修法；既解决 issue，又不改变 backend manifest 的独立可用性。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
